Reference attributes directly from cluster #7139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing to follow the convention
Reference the configuration/data directly from the cluster rather than specifying the data in-line. This seems to have broken the integration in a previous PR.
|
Looks good, thanks! |
lucasteligioridis
added a commit
to lucasteligioridis/zigbee-herdsman-converters
that referenced
this pull request
Mar 1, 2024
…-converters * 'master' of github.com:lucasteligioridis/zigbee-herdsman-converters: chore(master): release 18.42.0 (Koenkk#7140) fix(ignore): update dependencies (Koenkk#7141) feat: Support fanTimerMode for Inovelli VZM35-SN (Koenkk#7023) fix: Reference attributes directly from cluster for various Schneider Electric specific attributes (Koenkk#7139)
lucasteligioridis
added a commit
to lucasteligioridis/zigbee-herdsman-converters
that referenced
this pull request
Mar 2, 2024
This was changed in Koenkk#7139 and seemed to break this integration. Unsure as to why this is not working anymore as everything logically looks correct. For now lets revert this change and hope this resolves the bug and gets this part of the integration working again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change to referencing the attributes directly from the cluster object.
Full disclosure I've looked at the code and from what I understand this is how we should be referencing the data from the cluster, but I would also really need your help here to validate that this is correct. The current implementation doesn't seem to work correctly as hitting the "refresh" button didn't seem to update the value of these LEDs.
Can you please just confirm both this PR and the Koenkk/zigbee-herdsman#942 are compatible and that the integration should work in this way?