Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom cluster for SONOFF TRVZB #7432

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Apr 23, 2024

@sjorge
Copy link
Sponsor Contributor

sjorge commented Apr 23, 2024

Interesting, I was planning on having a modernExtend that did the onEvent hooking. But this works too I guess.

@photomoose
Copy link
Contributor

photomoose commented Apr 24, 2024

@Koenkk This merge appears to have broken writing attributes to Sonoff TRVZB - the TRVs are responding with 'Unsupported Attribute'.

Publish 'get' 'open_window' to 'Kitchen' failed: 'Error: ZCL command 0x3c2ef5fffebd4de2/1 sonoffTrvzbCluster.read(["openWindow"], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'

It looks like the addition of the Manufacturer Code in the ZCL Frame is the culprit; if I remove this line, then it works as expected.

I have attached traces of packets sent from Z2M and packets sent from eWeLink/ZB-Bridge. You can clearly see that eWeLink does not include the Manufacturer Code.

Traces.zip

I'll create a separate issue for this.

@Koenkk
Copy link
Owner Author

Koenkk commented Apr 25, 2024

thanks @photomoose, fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants