Unsupported Attribute when writing attributes to Sonoff TRVZB

[photomoose]

#7432 appears to have stopped the ability to write attributes to the Sonoff TRV (e.g. child lock, open window detection). The TRVs are responding with 'Unsupported Attribute':

Publish 'get' 'open_window' to 'Kitchen' failed: 'Error: ZCL command 0x3c2ef5fffebd4de2/1 sonoffTrvzbCluster.read(["openWindow"], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'

It looks like the addition of the Manufacturer Code in the ZCL Frame is the culprit; if I remove this line, then it works as expected.

I have attached traces of packets sent from Z2M and packets sent from eWeLink/ZB-Bridge. You can clearly see that eWeLink does not include the Manufacturer Code.

Traces.zip

[fir3drag0n]

I can confirm the problem: #7130

[einfachuli]

Exactly the same Problem here.

[photomoose]

From looking at previous commits/conversations, I assume the manufacturer code was included so that it is echoed in the response from the device, allowing Z2M to differentiate between different devices using the same cluster ID - so I'm not sure that simply removing the manufacturer code from the Sonoff cluster definition is the correct thing to do here. @Koenkk can you confirm?

[Koenkk]

@photomoose I pushed a fix, can you check if this is fixed now?

Changes will be available in the dev branch in a few hours from now.

[photomoose]

@Koenkk sure no problem, I've been running it locally (npm run start) so will check as soon as I finish my dinner! 😀

[hubi73]

I have tested the dev branch with zigbee-herdsman (0.43.1) but still get this error:

[2024-04-25 22:05:17] error: z2m: Publish 'get' 'valve_closing_degree' to 'TRV-Bad' failed: 'Error: ZCL command 0x38398ffffe020ee5/1 sonoffTrvzbCluster.read(["valveClosingDegree"], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4742,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
[2024-04-25 22:05:17] error: z2m: Exception while calling fromZigbee converter: Value is not a number, got undefined (undefined)}

edit: Now with zigbee-herdsman (0.43.1) AND zigbee-herdsman-converters v19.28.0 it runs without errors.

Thank you.

[photomoose]

@Koenkk looks like the changes in the customSonoffTrvzb cluster have fixed the issue. Thanks for the fix! Also checked the valve closing/opening degree issue raised by @hubi73 but this appears to be working fine for me, as shown in the attached traces.

Fixed.pcapng.zip

[photomoose]

Fixed by 99af051