fix(inovelli): add missing param 121 FanTimerMode #7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@InovelliUSA could you review this? |
|
@Koenkk any chance we can get this change in before the release? |
|
@InovelliUSA just bumping this. Thanks |
|
Yes, this looks good to be merged. |
|
Thanks! |
lucasteligioridis
added a commit
to lucasteligioridis/zigbee-herdsman-converters
that referenced
this pull request
Mar 1, 2024
…-converters * 'master' of github.com:lucasteligioridis/zigbee-herdsman-converters: chore(master): release 18.42.0 (Koenkk#7140) fix(ignore): update dependencies (Koenkk#7141) feat: Support fanTimerMode for Inovelli VZM35-SN (Koenkk#7023) fix: Reference attributes directly from cluster for various Schneider Electric specific attributes (Koenkk#7139)
lucasteligioridis
pushed a commit
to lucasteligioridis/zigbee-herdsman-converters
that referenced
this pull request
Mar 1, 2024
* fix(inovelli): add missing param 121 FanTimerMode * Update inovelli.ts --------- Co-authored-by: Koen Kanters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fanTimerMode was implemented on herdsman in Koenkk/zigbee-herdsman#881
new params were introduced in #6936 but fanTimerMode was missed, this PR adds that missing parameter