Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish translation #3

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Spanish translation #3

merged 1 commit into from
Sep 15, 2018

Conversation

Dorumin
Copy link
Contributor

@Dorumin Dorumin commented Sep 15, 2018 •
edited
Loading

New

  • All the messages Kocka added

Fixed

  • All the messages Unai messed up

Notes

  • This format is way too formal for what is just a translation PR
  • I didn't bother to bump the version patch, or update CONTRIBUTING.md to remove the Spanish outdated notice
  • Unai sucks

Pings

@KockaAdmiralac

@KockaAdmiralac KockaAdmiralac self-requested a review September 15, 2018 23:50
KockaAdmiralac
KockaAdmiralac approved these changes Sep 15, 2018
View reviewed changes
Copy link
Owner

@KockaAdmiralac KockaAdmiralac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment

  • Thanks!

Status

  • Approved

Notes

  • I might make a separate format for translation PRs and note it in guidelines nobody reads

@KockaAdmiralac KockaAdmiralac merged commit 4faccb2 into KockaAdmiralac:release-1.0.0 Sep 15, 2018
@Dorumin Dorumin deleted the release-1.0.0 branch September 15, 2018 23:56
@KockaAdmiralac KockaAdmiralac added this to the v1.0.0 milestone Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KockaAdmiralac KockaAdmiralac KockaAdmiralac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dorumin @KockaAdmiralac