[RFR] fix ssc default behavior : must use base branch comparison when no optional args are provided #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional args are provided PR [40](#40) has introduced a change in the default behavior of ssc. When running the tool as usual, there was an error raised : ``` $ ssc --path <path> --cmd <stop_command> error: a value is required for '--base-ref <BASE_REF>' but none was supplied ``` whereas it should use the base branch comparison by default (as we don't want people who are upgrading ssc to change their CI scripts). This commit fixes this issue.
alexpozzi
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 40 has introduced a change in the default behavior of ssc. When running the tool as usual, there was an error raised :
whereas it should use the base branch comparison by default (as we don't want people who are upgrading ssc to change their CI scripts).
This commit fixes this issue.