-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #649 - Remove useless files from users and servers #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help on improving Gaufrette. This could be part of the next release (coming soon) but I think you may have excluded too much files if I follow the logic of your PR description.
composer.json
Outdated
"archive": { | ||
"exclude": [ | ||
"/tests", | ||
"/phpunit.xml.dist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spec folder and phpspec config file should be here to follow the logic entirely (it's part of the test suite). The .env.dist file is also absolutely required, as well as the make file.
Very cool ! |
TBH there's a bit of cleanup to do about this... Many config files and build-related stuff are sooo outdated... Maybe gonna work on this. But your work is nice thank you. |
Thank you, feel free to ping me for review on build stuff |
Thank you very much @williamdes ! |
Hi !
I did this change in two steps, first I excluded the files from the git archive:
git archive --help
. GitHub usesgit archive
for users to be able to "Download" a branch or git tag.So I kept the test files and the phpunit config in it because: packing people on Debian/Alpine/Others... will download the source using scripts and do not want to have to clone your git history because they do not care about it and only want the source.
That said this is not what composer users want. They only want source file, so I excluded test files from the bundles that packagist produces.
Final users will only have source files, packaging people will have source+tests and devs can use git clone.
Fixes: #649