Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #627

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Test enhancement #627

merged 1 commit into from
Oct 24, 2019

Conversation

peter279k
Copy link
Contributor

Changed log

  • According to the PHPUnit fixtures reference, the setUp and tearDown methods should be protected, not public.
  • There're two approaches to mark test method on PHPUnit tests.
    One is method name with test prefix. and another one is using @test comment annotation on specific method name.
    To be consistency, let these methods be used with prefix.

nm2107
nm2107 reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@nm2107 nm2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ;)

tests/Gaufrette/Functional/Adapter/AwsS3Test.php Outdated Show resolved Hide resolved
tests/Gaufrette/Functional/Adapter/AwsS3Test.php Outdated Show resolved Hide resolved
tests/Gaufrette/Functional/Adapter/AwsS3Test.php Outdated Show resolved Hide resolved
tests/Gaufrette/Functional/Adapter/AwsS3Test.php Outdated Show resolved Hide resolved
tests/Gaufrette/Functional/Adapter/GridFSTest.php Outdated Show resolved Hide resolved
tests/Gaufrette/Functional/Adapter/GridFSTest.php Outdated Show resolved Hide resolved
tests/Gaufrette/Functional/Adapter/GridFSTest.php Outdated Show resolved Hide resolved
tests/Gaufrette/Functional/FileStream/LocalTest.php Outdated Show resolved Hide resolved
@peter279k
Copy link
Contributor Author

thank you ;)

Thanks for your typo fix :).

@peter279k peter279k requested a review from nm2107 October 24, 2019 06:12
nm2107
nm2107 approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@nm2107 nm2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ;)

@nm2107 nm2107 merged commit 2216a72 into KnpLabs:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nm2107 nm2107 nm2107 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @nm2107