[RFR] Add PHP Coding Standard check step on CI. #617
Conversation
nicolasmure
changed the title
| 'gid' => 1, | ||
| 'rdev' => 0, | ||
| 'size' => 666, | ||
| 'uid' => 123, |
There was a problem hiding this comment.
IMHO would be better to keep things aligned here
There was a problem hiding this comment.
Actually I'm not fan of aligning things, as it will make changes on other lines as soon as a big line is introduced ; and thus, making a new commit for these lines, whereas they were not significantly changed.
To me, it's the same issue than the trailing comma at the end of array items. Before if was supported, adding a new item to a list was producing a git diff of two lines : the actual line and the above one to add a comma. Only the actual line had a sense for the git diff.
That's why I prefer not to keep things aligned. Only alphabetic sort should improve readability IMHO.
| MetadataSupporter | ||
| class AclAwareAmazonS3 implements | ||
| Adapter, | ||
| MetadataSupporter |
There was a problem hiding this comment.
Maybe just put everything on a single line? 🤔
|
What about using PedroTroller/PhpCSFixer-Custom-Fixers and keep a single php_cs config file? |
Only run the
php-cs-comparemake target on travis ASAP to fail the build when the CS are violated.Also, expose a
php-cs-fixmake target to fix the violations.