[RFR] Define env vars in .env file only #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are using env vars to run. These env vars are storing the credentials to the different backends. For the CI, these env vars are set on the project settings (on travis for instance). For the development of Gaufrette, and considering the merge of (#580), the tests should be ran using docker. The docker setup uses env vars defined in .env files, so we no longer need to define such vars in the phpunit.xml file.
akerouanton
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are using env vars to run. These env vars are storing the
credentials to the different backends.
For the CI, these env vars are set on the project settings (on travis
for instance).
For the development of Gaufrette, and considering the merge of #580,
the tests should be ran using docker.
The docker setup uses env vars defined in .env files, so we no longer
need to define such vars in the phpunit.xml file.