[Local Adapter] directory deletion #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasmure
force-pushed
the
feature/local-adapter-delete-directory
branch
4 times, most recently
from
334c143 to
ee26475
Compare
akerouanton
reviewed
Jun 4, 2019
nicolasmure
force-pushed
the
feature/local-adapter-delete-directory
branch
from
ee26475 to
0013457
Compare
akerouanton
approved these changes
Jun 5, 2019
nicolasmure
force-pushed
the
feature/local-adapter-delete-directory
branch
from
0013457 to
8b23f73
Compare
|
Thank you @athos7933 ! |
This was referenced Jun 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #582 (cherry picked)
As @NiR- pointed out, Gaufrette (and so the Filesystem) do not aim to support directories.
We only support objects identified by keys. However, the directory deletion seems to be a requested feature by the community. This PR completes the requested changes of #582.
As the directory deletion is very specific to the Local Adapter, you have to explicitely retrieve the adapter in order to use it :