Adding SizeCalculator support to GridFS #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasmure
reviewed
Jan 28, 2019
src/Gaufrette/Adapter/GridFS.php
Outdated
|
|
||
| public function size($key) | ||
| { | ||
| if(!$this->exists($key)) { |
There was a problem hiding this comment.
Can you apply the PSR2 coding style please ?
| if(!isset($size['length'])) { | ||
| return false; | ||
| } | ||
| return $size['length']; |
There was a problem hiding this comment.
same about return statement; PSR2 says it should have an empty line before it ;)
| public function testSize() | ||
| { | ||
| $this->filesystem->write('sizetest.txt', 'data'); | ||
| $this->assertGreaterThan(0, $this->filesystem->size('sizetest.txt')); |
There was a problem hiding this comment.
Shouldn't the returned value be equal to 4 (length of data) ?
You can run this test by putting your gridFS credentials in the phpunit.xml file (copied from the phpunit.xml.dist file).
There was a problem hiding this comment.
Good point, I overthought it, it's changed
bsperduto
force-pushed
the
rel/gridfs-size-calculator
branch
from
d57c8af to
17313c5
Compare
nicolasmure
approved these changes
Jun 4, 2019
|
Thank you @bsperduto ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the SizeCalculator interface to the GridFS adapter.