Implement ChecksumCalculator Interface #594
Merged
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #590. |
|
Hello @damijank :) Thank you for your contribution, do you mind to add a test covering your changes ? Thanks ;) |
|
@nicolasmure there's the test case :) |
nicolasmure
reviewed
Dec 13, 2018
| $this->filesystem->write($path, $content); | ||
| $checksumBase64 = $this->filesystem->checksum($path); | ||
|
|
||
| $this->assertEquals(\md5($content), \bin2hex(\base64_decode($checksumBase64, true))); |
There was a problem hiding this comment.
I'm not sure to get your test here. Why to call again bin2hex and base64_decode ?
Shouldn't the test be
$checksum = $this->filesystem->checksum($path);
$this->assertEquals(\md5($content), $checksum);?
There was a problem hiding this comment.
Yup, you are right. I was too quick with this. Sending fix right away.
nicolasmure
approved these changes
Dec 13, 2018
|
Thank you @damijank ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application is handling videos, the method to download the file locally and calculate the MD5 hash is not feasible. Azure calculates the MD5 hash, this PR implements fetching MD5 info from Azure.