Changed rake task in minitest_runner.rb to have no warnings output #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturT
added a commit
that referenced
this pull request
Mar 18, 2016
Changed rake task in minitest_runner.rb to have no warnings output
ArturT
added a commit
to KnapsackPro/knapsack
that referenced
this pull request
Mar 18, 2016
|
@patrickbizea I've released knapsack_pro 0.6.1 version. Thank you for PR! |
|
I've released this fix also in knapsack gem https://github.com/ArturT/knapsack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in this PR on Rake itself, executing the minitest rake task for Knapsack caused our test output to be filled with so many extraneous warning messages during test execution it both caused the output to be unreadably long and caused the semaphoreci threads to error out, apparently due to lack of memory. This reverts the setting for warnings on the Rake task defined in minitest_runner.rb to the pre-Rake v11.0.0 default, resolving both issues.