Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of call #zero? method on $?.exitstatus #52

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Get rid of call #zero? method on $?.exitstatus #52

merged 1 commit into from
Dec 1, 2016

Conversation

ilyasgaraev
Copy link

$?.exitstatus returns the least significant eight bits of the return code of stat and the method returns fixnum or nil.
If $?.exitstatus returns nil, $?.exitstatus.zero?crashes with a NoMethodError:

NoMethodError: undefined method `zero?' for nil:NilClass

@ArturT ArturT merged commit e653f77 into KnapsackPro:master Dec 1, 2016
@ArturT
Copy link
Member

ArturT commented Dec 1, 2016

@ilyasgaraev Thanks for the PR. I've released knapsack v1.13.1.

@ilyasgaraev ilyasgaraev deleted the get-rid-of-call-zero-method-on-exitstatus branch December 1, 2016 12:25
@ArturT ArturT mentioned this pull request Dec 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilyasgaraev @ArturT