Fix example group issue with turnip #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevio
commented
Oct 1, 2016
tevio
commented
- the previous fix for this - Add support for Turnip features #19 - does not work with Rails 4.2.6, turnip 2.1.1, rspec 3.4.0 & knapsack latest, this fixes that fix
ArturT
reviewed
Oct 1, 2016
| @@ -48,10 +48,8 @@ def bind_time_offset_warning | |||
| end | |||
|
|
|||
| def self.test_path(example_group) | |||
| unless example_group[:turnip] | |||
There was a problem hiding this comment.
Would be good to still have backward compatibility with Turnip 1.x
You could check if Turnip exists and if the version is bellow 2.x then follow old approach.
if defined?(Turnip) && Turnip::VERSION.to_i < 2and we need test for both cases.
ArturT
reviewed
Oct 1, 2016
| @@ -100,10 +100,10 @@ | |||
| context 'with turnip features' do | |||
| let(:current_example_metadata) do | |||
| { | |||
| file_path: "./spec/features/logging_in.feature", | |||
| file_path: "gems/turnip-1.2.4/lib/turnip/rspec.rb", | |||
There was a problem hiding this comment.
here is example with hard coded turnip version 1.2.4 it could be x.x.x
|
@ArturT I've added the extra case for Turnip <= 2, let me know if there is anything else needs doing on this PR :) |
|
@tevio PR looks good. Thank you! I'm going to merge it and release a new gem version by the end of this week. |
|
@tevio I've released version 1.12.2. Thanks for PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.