Use Knapsack.logger for runner output #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the different runners use `puts` to directly print their output to STDOUT. This commit changes them to use Knapsack.logger at INFO level. By default this will still print to STDOUT as before, but allows users to send this output elsewhere, or suppress it with a higher log level if desired.
urbanautomaton
force-pushed
the
use-logger-in-test-runners
branch
from
0203579
to
984a532
Compare
|
@urbanautomaton Thanks for PR! I've just released knapsack 1.9.0 with this improvement. |
|
Thanks @ArturT! And, as always, thanks for making the gem. 👍 |
|
I've just realized that I forgot to push 1.9.0 version to rubygems yesterday. Now it's there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the different runners use
putsto directly print their output to STDOUT. It would be really helpful to be able to suppress this output in certain contexts, or send it to a different location.This commit changes them to use Knapsack.logger at INFO level. By default this will still print to STDOUT as before, but allows users to send the output elsewhere, or suppress it with a higher log level if desired.