Change file path patterns to support 1-level symlinks by default #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👌 Thanks! |
ArturT
added a commit
to KnapsackPro/knapsack_pro-ruby
that referenced
this pull request
Nov 11, 2015
ArturT
added a commit
to KnapsackPro/knapsack_pro-ruby
that referenced
this pull request
Nov 11, 2015
…est file pattern supporting symlinks (Related PR: KnapsackPro/knapsack#27)
ArturT
added a commit
that referenced
this pull request
Nov 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to use knapsack to run RSpec that is symlink-ed to a different directory, me and my team spent a fair amount of time trying to figure out why Knapsack wouldn't load our knapsack reports correctly.
After digging into the knapsack code, we found out that by default, the file path pattern provided by default does not follow symlinks.
I would like to propose that we support follow at least 1-level symlinks by default