Raise error when CI_NODE_INDEX >= CI_NODE_TOTAL #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contribution. :) |
ArturT
pushed a commit
that referenced
this pull request
Feb 15, 2015
Raise error when CI_NODE_INDEX >= CI_NODE_TOTAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the great work on this! Very helpful.
I was just bit by this issue: when the
CI_NODE_INDEXis equal or higher thanCI_NODE_TOTALknapsack blows up in a non-obvious way and the user may not be aware of what is causing the issue. I added a sanity check for this on BaseDistributor.Hope you find this useful.