Update time offset warning #105
Conversation
ArturT
commented
Apr 13, 2021
ArturT
commented
- Show link to article explaining how Queue Mode works
- Show suggestion to automatically split test files.
lib/knapsack/presenter.rb
Outdated
| @@ -51,10 +51,15 @@ def time_offset_warning | |||
| } | |||
| if Knapsack.tracker.time_exceeded? | |||
| str << %{ | |||
| Tests on this CI node took more than max allowed node time execution. | |||
| Tests on this CI node took more than the max allowed node time execution. | |||
There was a problem hiding this comment.
idea for lingo improvements:
Test on this CI node ran for longer than the max allowed node time execution.
lib/knapsack/presenter.rb
Outdated
| If that didn't help then split your heavy test file | ||
| or bump time_offset_in_seconds setting.} | ||
|
|
||
| If that didn't help then split your slow test file into smaller test files |
There was a problem hiding this comment.
Consider:
If that doesn't help, you can split your slowest test files into smaller files, or bump up the time_offset_in_seconds setting.
lib/knapsack/presenter.rb
Outdated
| If that didn't help then split your slow test file into smaller test files | ||
| or bump time_offset_in_seconds setting. | ||
|
|
||
| You can also use knapsack_pro gem to automatically divide slow test files between parallel CI nodes. |
There was a problem hiding this comment.
How about:
You can also allow the knapsack_pro gem to automatically divide your slow test files across parallel CI nodes.
lib/knapsack/presenter.rb
Outdated
| @@ -64,8 +69,8 @@ def time_offset_warning | |||
| str << "\nhttps://docs.knapsackpro.com/ruby/knapsack#faq" | |||
| str << "\n=================================================\n" | |||
| str << %{See how to split tests in a dynamic way using Queue Mode to ensure all parallel nodes | |||
| finish work at a similar time even when your CI or random test execution is a bottleneck: | |||
| https://youtu.be/hUEB1XDKEFY | |||
| finish work at a similar time even when your CI server or a random tests execution time is a bottleneck: | |||
There was a problem hiding this comment.
This might be a little unclear to some imho. Maybe we can simplify this to sth plain like:
Read up on the benefits of a dynamic test split with Knapsack's Queue Mode:
What do you think?
There was a problem hiding this comment.
good point. The article explains it.
…ler files, or bump up the time_offset_in_seconds setting.
