-
-
Notifications
You must be signed in to change notification settings - Fork 862
Fix test_loop_auto for Python 3.14 #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_loop_auto for Python 3.14 #2652
Conversation
In Python 3.14, asyncio.events.BaseDefaultEventLoopPolicy, which was always a private/undocumented API, was renamed with a leading underscore. See python/cpython#131148.
This is probably less clear than the previous implementation, but it should achieve the artificial metric of 100% test-line coverage.
c1cbd7f to
4287e25
Compare
|
I'll close this PR since we remove that logic from master. Does master still fail on 3.14? |
It’s a bit awkward to test the Fedora package right now, as we’re in the middle of a datacenter move for Fedora infrastructure, but in a quick trial in a git checkout: The So it looks like at least in a virtualenv, there’s just one “real” regression in Python 3.14.0b3. Results might be a little different in Fedora due to things like different dependency versions. |
|
Summary
In Python 3.14,
asyncio.events.BaseDefaultEventLoopPolicy, which was always a private/undocumented API, was renamed with a leading underscore. See python/cpython#131148.This PR adapts
test_loop_auto, which contains a type check against this undocumented type, to support either name depending on the interpreter version, fixing failures like the following on Python 3.14:Checklist