Skip to content

Fix missing self.servers exception #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Archmonger wants to merge 4 commits into from
Closed

Fix missing self.servers exception #1845

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9eb1218
Fix missing self.servers exception
Archmonger Jan 12, 2023
5b34e67
Fix type hints
Archmonger Jan 13, 2023
5a6032b
add servers.clear()
Archmonger Feb 13, 2023
bb60ec0
format with black
Archmonger Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions uvicorn/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import time
from email.utils import formatdate
from types import FrameType
from typing import TYPE_CHECKING, List, Optional, Sequence, Set, Tuple, Union
from typing import TYPE_CHECKING, Any, List, Optional, Sequence, Set, Tuple, Union

import click

Expand Down Expand Up @@ -54,6 +54,7 @@ def __init__(self, config: Config) -> None:
self.should_exit = False
self.force_exit = False
self.last_notified = 0.0
self.servers: List[Any] = []

def run(self, sockets: Optional[List[socket.socket]] = None) -> None:
self.config.setup_event_loop()
Expand Down Expand Up @@ -112,7 +113,9 @@ def _share_socket(
sock_data = sock.share(os.getpid()) # type: ignore[attr-defined]
return fromshare(sock_data)

self.servers = []
# Ensure list does not have stale items if the server is run multiple times.
self.servers.clear()

for sock in sockets:
if config.workers > 1 and platform.system() == "Windows":
sock = _share_socket( # type: ignore[assignment]
Expand Down