Skip to content

📦️ Add PEP440 compliant version of click#1099

Merged
euri10 merged 2 commits intomasterfrom
fix/pep440
Jun 29, 2021
Merged

📦️ Add PEP440 compliant version of click#1099
euri10 merged 2 commits intomasterfrom
fix/pep440

Conversation

@Kludex
Copy link
Owner

@Kludex Kludex commented Jun 28, 2021

Fixes #1098.

@euri10
Copy link
Contributor

euri10 commented Jun 28, 2021

lint fails on

uvicorn/middleware/proxy_headers.py:13: error: Module "asgiref.typing" has no attribute "WebsocketScope"; maybe "WebSocketScope"?  [attr-defined]

@Kludex
Copy link
Owner Author

Kludex commented Jun 28, 2021

That's so funny. 😅 I was the one who changed that interface on asgiref: django/asgiref#272

It's not from this PR :)
master branch is broken. I'm going to fix it.

Copy link
Contributor

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci is failing not sure why

edit: also not sure why I' doing thingss twice, sorry for that

@euri10 euri10 merged commit 62825d3 into Kludex:master Jun 29, 2021
@euri10
Copy link
Contributor

euri10 commented Jun 29, 2021

thanks @Kludex

Kludex added a commit that referenced this pull request Nov 17, 2021
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PackageInfo: Invalid constraint (click (>=7.*)) found in uvicorn-0.14.0 dependencies, skipping

2 participants