TestClient timeout simulates http.disconnect

[fantix]

So that on the server side, http.disconnect can be received when timed out.

[blueyed]

Looks interesting. I've quickly tried if it would abort an await asyncio.sleep(5), but that does not appear to be the case. Would it possible to handle this? (i.e. that the timeout for client.get would ensure that it takes no longer than that)

[fantix]

Oh, this patch only added timeout feature to the TestClient and the requests-powered ASGI "server". That means, on timeout, the TestClient will "disconnect" the connection, and an http.disconnect event is raised in the ASGI "server". However, it is totally up to the ASGI application to handle the http.disconnect event - whether abort the current handling task or whatever else. Please see an example here where we abort any pending request handlers when http.disconnect is detected.

[Kludex]

Thanks for the PR @fantix ! Sorry for taking so long to act here 😅

I think this feature is extremely useful. It's going to be useful to test StreamingResponse, a bug we have on BaseHTTPMiddleware and also another PR that is coming around that needs a test when the client disconnects.

I'll be closing this issue, and proceed with it on #1446. I've co-authored yourself, as I've just adapted this code.