Fix: Raise WebSocketDisconnect instead of RuntimeError on closed conn…#3074
Closed
Manas-sin wants to merge 3 commits intoKludex:mainfrom
Closed
Fix: Raise WebSocketDisconnect instead of RuntimeError on closed conn…#3074Manas-sin wants to merge 3 commits intoKludex:mainfrom
Manas-sin wants to merge 3 commits intoKludex:mainfrom
Conversation
added 3 commits
November 26, 2025 10:31
Owner
|
But this doesn't make sense; the client isn't supposed to see those error messages. Let's continue the discussion on the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the generic
RuntimeErrorwith WebSocketDisconnect (code 1006) when attempting to send or receive messages on a WebSocket connection that has already been closed.This improves error handling by allowing applications to catch a specific exception type instead of relying on string matching for
RuntimeError.Fixes #2767.
Checklist