Allow relative directory path when follow_symlinks=True#2896
Merged
Kludex merged 3 commits intoKludex:masterfrom Mar 8, 2025
Merged
Allow relative directory path when follow_symlinks=True#2896Kludex merged 3 commits intoKludex:masterfrom
follow_symlinks=True#2896Kludex merged 3 commits intoKludex:masterfrom
Conversation
…th") that stopped working with commit eee4cdc
This was referenced Mar 5, 2025
Kludex
approved these changes
Mar 8, 2025
Owner
Kludex
left a comment
There was a problem hiding this comment.
Thanks. I left only the test that was failing in master.
follow_symlinks=True
Contributor
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for StaticFiles(follow_symlinks=True, directory="some relative path") that stopped working with commit eee4cdc.
When using StaticFiles with a relative path (e.g. a static folder included with the source code deployment) and follow_symlinks is set to True, the commit at eee4cdc removed the code that translates the relative folder into an absolute folder, and then the system call os.path.commonpath fails because it expects the arguments to either be all relative or all absolute.
This MR fixes this issue by using the same pattern as the full_path - os.abspath for follow_symlinks=True, and os.realpath when False.
Checklist