Use localhost instead of http://localhost in TestClient(client=...) example#2870
Merged
Kludex merged 1 commit intoKludex:masterfrom Feb 16, 2025
Merged
Conversation
With Kludex#2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address). The default value for `TestClient` is `testclient`, but an IP address in most circumstances. The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
Kludex
approved these changes
Feb 16, 2025
Kludex
changed the title
localhost instead of http://localhost in TestClient(client=...) example
Owner
|
Thanks 🙏 |
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With #2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address).
The default value for
TestClientistestclient, but an IP address in most circumstances.The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
Checklist