Do not process FileNotFoundError in FileResponse, resolves #979#2856
Open
toxadx wants to merge 2 commits intoKludex:mainfrom
Open
Do not process FileNotFoundError in FileResponse, resolves #979#2856toxadx wants to merge 2 commits intoKludex:mainfrom
toxadx wants to merge 2 commits intoKludex:mainfrom
Conversation
FileNotFoundError can be processed in exception_handlers
Kludex
requested changes
Feb 8, 2025
Owner
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
Can you show me a real example of what you are trying to do?
The client asks for a file, and you use FileResponse? What about StaticFiles?
| raise RuntimeError(f"File at path {self.path} does not exist.") | ||
| pass | ||
| else: | ||
| mode = stat_result.st_mode |
Owner
There was a problem hiding this comment.
2 lines below, we have another RuntimeError.
Also, this is a breaking change.
Contributor
There was a problem hiding this comment.
We can raise a new exception derived from both RuntimeError and FileNotFoundError. This way we can keep backward compatibility.
class NotFoundError(FileNotFoundError, RuntimeError): ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileNotFoundError can be processed in exception_handlers
Summary
Avoid handling FileNotFoundError in FileResponse.
This allows FileNotFoundError to be properly handled using exception_handlers, for example, by returning a 404 error when a file is not found.
Checklist