Get iscoroutinefunction() from inspect rather than asyncio#2855
Merged
Kludex merged 1 commit intoKludex:masterfrom Jan 28, 2025
Merged
Conversation
Python 3.14.0a3 issues a DeprecationWarning for asyncio.iscoroutinefunction(), stating that it is deprecated and slated for removal in Python 3.16 and recommending inspect.iscoroutinefunction() instead. This change resolves that DeprecationWarning.
Kludex
approved these changes
Jan 28, 2025
Owner
|
Thanks @musicinmybrain |
Owner
|
Do you need a release or you fetch from master? |
Contributor
Author
Thanks for asking. I can easily apply https://github.com/encode/starlette/pull/2855.patch for now, so there’s no hurry to issue a release. I think I’m stuck on Starlette 0.45.0 in Fedora for now anyway, until we can get our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14.0a3 issues a
DeprecationWarningforasyncio.iscoroutinefunction(), stating that it is deprecated and slated for removal in Python 3.16, and recommendinginspect.iscoroutinefunction()instead. This change resolves thatDeprecationWarning.Summary
Running the tests with Python 3.14.0a3 fails with several errors like:
This PR just implements the recommended migration from
asyncio.iscoroutinefunction()toinspect.iscoroutinefunction()instarlette/_utils.py. Note thatstarlete/routing.pyalready usesinspect.iscoroutinefunction()even before this PR:https://github.com/encode/starlette/blob/4d72fd87ea1c358691a19468168f7217d8ca6a87/starlette/routing.py#L55
Checklist