tests: branch coverage in _utils.py, middleware/gzip.py, routing.py and requests.py#2816
Merged
Kludex merged 3 commits intoKludex:masterfrom Dec 28, 2024
Merged
Conversation
….py` and `requests.py`
_utils.py, middleware/gzip.py, routing.py and requests.pybranch = true in coverage.run
Kludex
approved these changes
Dec 28, 2024
branch = true in coverage.run_utils.py, middleware/gzip.py, routing.py and requests.py
Kludex
reviewed
Dec 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to Issue #2452
This PR covers all 9 missing cases.
starlette/_utils.py78–82Extend the
# pragma: no coverto include the condition.starlette/middleware/gzip.py16–22, 91–endRelated to conditional cases with scope type and message type.
Added
# pragma: no branchto all cases.starlette/routing.py199–202, 401–430, 484–496Related to conditional cases where the scope type is not 'http' or 'websocket'.
Added
# pragma: no branchto all cases.starlette/requests.py114–116, 233–225, 253–278Although it's from
requests.py, the test related to lines 114–116 was added intest_routing.py.For the other two cases,
# pragma: no branchwas added.Checklist