Make UUID path parameter conversion more flexible#2806
Merged
Kludex merged 3 commits intoKludex:masterfrom Dec 25, 2024
Merged
Conversation
Kludex
requested changes
Dec 17, 2024
Owner
Kludex
left a comment
There was a problem hiding this comment.
This is fine. 🙏
Just a minor nitpick, as I think our test suite focus a lot on readability.
cbc7f87 to
85e92be
Compare
Kludex
approved these changes
Dec 17, 2024
Owner
|
Thanks @edthrn 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on @adriangb suggestion made in this discussion thread, here is a more flexible conversion of UUID path parameters.
UUID representation may vary depending on the system from which it is generated. Some systems may return an hex representation with no hyphens, while some others use upper-case letters.
From Python perspective, they are all valid:

Not handling those cases may yield to hard-to-debug 404 errors.
Checklist