Fail fast on invalid Jinja2Template instantiation parameters#2568
Merged
Kludex merged 2 commits intoKludex:masterfrom Apr 20, 2024
Merged
Fail fast on invalid Jinja2Template instantiation parameters#2568Kludex merged 2 commits intoKludex:masterfrom
Kludex merged 2 commits intoKludex:masterfrom
Conversation
Calling `Jinja2Template()` with both `directory` and `env` shouldn't be allowed. When both parameters were used, the passed `env` was silently ignored in favor of creating a new one with the provided `directory` and the deprecated `env_options`.
pdelagrave
force-pushed
the
fix_templates_env_dir
branch
from
402545d to
05c1d10
Compare
Kludex
approved these changes
Apr 20, 2024
Owner
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
This reflects the overrides. 👍
I think we should probably remove this assertion at some point... The type checker is able to catch this anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calling
Jinja2Template()with bothdirectoryandenvshouldn't be allowed. When both parameters were used, the passedenvwas silently ignored in favor of creating a new one with the provideddirectoryand the deprecatedenv_options.Checklist