Skip to content

Inherit from HTMLResponse instead of Response on _TemplateResponse (#2272) #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kludex merged 1 commit into from
Sep 7, 2023
+2 −4
Merged

Inherit from HTMLResponse instead of Response on _TemplateResponse (#2272) #2274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions starlette/templating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from starlette.background import BackgroundTask
from starlette.datastructures import URL
from starlette.requests import Request
from starlette.responses import Response
from starlette.responses import HTMLResponse
from starlette.types import Receive, Scope, Send

try:
Expand All @@ -23,9 +23,7 @@
jinja2 = None # type: ignore[assignment]


class _TemplateResponse(Response):
media_type = "text/html"

class _TemplateResponse(HTMLResponse):
def __init__(
self,
template: typing.Any,
Expand Down