-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Clarify lifespan vs on_startup/on_shutdown priority #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
64d613a
Clarify lifespan vs on_startuo/on_shutdown priority
stratosgear 6e08ac7
Remove docs warning and add a warning log message.
stratosgear bc42b41
Test UserWarning when lifespan used w/ on_events
stratosgear 6529146
Update routing.py
Kludex ec6c479
Update tests/test_routing.py
Kludex f576ba2
Update tests/test_routing.py
Kludex 405f13d
Update starlette/routing.py
Kludex 7024659
Update tests/test_routing.py
Kludex 90c793c
Trying to make the tests pass
stratosgear d6c960d
More tests tweaking
stratosgear d54b4a0
Fix tests
Kludex 2a3701e
Merge branch 'master' into patch-1
Kludex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.