Conversation
adriangb
approved these changes
Jun 19, 2023
alex-oleshkevich
approved these changes
Jun 19, 2023
adriangb
reviewed
Jun 19, 2023
rkazinets
approved these changes
Jun 19, 2023
3 tasks
Owner
Author
|
I'll make the next release with 3.7, then I'll merge this. |
abersheeran
reviewed
Jul 6, 2023
starlette/applications.py
Outdated
| # TODO: Make `__name` a positional-only argument when we drop Python 3.7 support. | ||
| def url_path_for(self, __name: str, **path_params: typing.Any) -> URLPath: | ||
| return self.router.url_path_for(__name, **path_params) | ||
| def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath: |
Contributor
There was a problem hiding this comment.
Is there a mistake here?
Owner
Author
There was a problem hiding this comment.
It isn't supposed to be... Why do you think it is?
Contributor
There was a problem hiding this comment.
I recall from our earlier discussion that name should be a positional-only parameter.
Maybe it should be changed to (self, name: str, /, **path_params: typing.Any)
Owner
Author
There was a problem hiding this comment.
Ah, it's a mistake! 🤣
Thanks! 🙏
Kludex
force-pushed
the
burn/drop-python-3.7
branch
from
793c030 to
3ace695
Compare
abersheeran
approved these changes
Jul 8, 2023
zanieb
approved these changes
Jul 8, 2023
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.7 EOL is coming: https://endoflife.date/python.