Skip to content

Allow "name" argument on templates url_for() #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kludex merged 2 commits into from
May 31, 2023
Merged

Allow "name" argument on templates url_for() #2127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c31265b
Allow "name" argument on templates url_for()
rosstitmarsh Apr 20, 2023
705a6b4
Merge branch 'master' into master
Kludex May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions starlette/templating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,11 @@ def _create_env(
self, directory: typing.Union[str, PathLike], **env_options: typing.Any
) -> "jinja2.Environment":
@pass_context
def url_for(context: dict, name: str, **path_params: typing.Any) -> URL:
# TODO: Make `__name` a positional-only argument when we drop Python 3.7
# support.
def url_for(context: dict, __name: str, **path_params: typing.Any) -> URL:
request = context["request"]
return request.url_for(name, **path_params)
return request.url_for(__name, **path_params)

loader = jinja2.FileSystemLoader(directory)
env_options.setdefault("loader", loader)
Expand Down