Skip to content

Comments

Allow "name" argument on url_for() and url_path_for()#2050

Merged
Kludex merged 4 commits intomasterfrom
fix/url-for-name
Mar 6, 2023
Merged

Allow "name" argument on url_for() and url_path_for()#2050
Kludex merged 4 commits intomasterfrom
fix/url-for-name

Conversation

@Kludex
Copy link
Owner

@Kludex Kludex commented Mar 1, 2023

Co-authored-by: Daniel <709115+dansan@users.noreply.github.com>
@Kludex Kludex requested a review from a team March 1, 2023 11:54
@Kludex
Copy link
Owner Author

Kludex commented Mar 3, 2023

@encode/maintainers 👀 🙏

@adriangb
Copy link
Contributor

adriangb commented Mar 3, 2023

This looks good to me. But admittedly I don't really use this functionality so I'd like someone who actually uses this to be the one approving ✅

@Kludex
Copy link
Owner Author

Kludex commented Mar 5, 2023

I want to make a premature release with the lifespan state that was included, but since I included #1385, it may be good to also include this in the release. 😅

@alex-oleshkevich @abersheeran would you mind checking this? 🙏

Copy link
Contributor

@abersheeran abersheeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel very good. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"url_for" signature prevents use of "name" in path arguments

3 participants