Merged
Conversation
Kludex
reviewed
Jun 1, 2022
Kludex
requested changes
Jun 4, 2022
Owner
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
Remember to share the GitHub release link. 🙏
Thanks for this @aminalaee ! 🎉
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Contributor
Author
|
@Kludex Done. |
Kludex
approved these changes
Jun 4, 2022
docs/release-notes.md
Outdated
|
|
||
| ### Fixed | ||
| * Fix regression on route paths with colons [#1675](https://github.com/encode/starlette/pull/1675). | ||
| * Allow staticfiles to follow symlinks [#1337](https://github.com/encode/starlette/pull/1377). |
Owner
There was a problem hiding this comment.
Is this an addition or really a fix? I don't care. Just questioning in case.
Contributor
Author
There was a problem hiding this comment.
Yeah it's a bit hard to tell, internally it was designed this way, but from the issue this is introduced as a bug. Open to suggestion though.
Kludex
reviewed
Jun 7, 2022
Kludex
reviewed
Jun 7, 2022
Owner
|
Comparison against tag: 0.20.1...master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/encode/starlette/releases/edit/untagged-04950ac69ee236fc5551