Skip to content

Set more_body to False when chunk is b""#1608

Closed
Kludex wants to merge 1 commit intomasterfrom
no-more-body
Closed

Set more_body to False when chunk is b""#1608
Kludex wants to merge 1 commit intomasterfrom
no-more-body

Conversation

@Kludex
Copy link
Owner

@Kludex Kludex commented Apr 29, 2022 •
edited
Loading

Questions

  • Is this really correct?

Missing:

  • Test

@Kludex Kludex added the bug Something isn't working label Apr 29, 2022
@Kludex Kludex requested a review from abersheeran April 29, 2022 19:30
@Kludex Kludex mentioned this pull request Apr 29, 2022
Merged
@Kludex
Copy link
Owner Author

Kludex commented Apr 29, 2022

#1579 looks more correct than this.

@Kludex Kludex closed this Apr 29, 2022
@Kludex Kludex deleted the no-more-body branch April 29, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abersheeran abersheeran Awaiting requested review from abersheeran

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gzip Middleware content-length is incorrect

1 participant

@Kludex