Merged
Conversation
Kludex
commented
Apr 28, 2022
aminalaee
reviewed
May 1, 2022
docs/release-notes.md
Outdated
| April 28, 2022 | ||
|
|
||
| ### Removed | ||
| * Drop Python 3.6 support [#1357](https://github.com/encode/starlette/pull/1357). |
Contributor
There was a problem hiding this comment.
Shouldn't the checklist be added here?
Owner
Author
There was a problem hiding this comment.
What items do you think should be included?
Owner
Author
There was a problem hiding this comment.
We don't have written rules for the changelog on starlette, but tests, docs and type hints modifications were never included.
Contributor
There was a problem hiding this comment.
Yeah I meant the doc changes, but you're right, they were never part of release changes.
aminalaee
reviewed
May 2, 2022
docs/release-notes.md
Outdated
| @@ -1,3 +1,11 @@ | |||
| ## 0.20.0 | |||
|
|
|||
| April 28, 2022 | |||
Contributor
There was a problem hiding this comment.
Friendly reminder about this :)
Owner
Author
There was a problem hiding this comment.
Thanks! I would have forgotten! 😅
aminalaee
approved these changes
May 2, 2022
Kludex
commented
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Release Draft: Version 0.20.0 Draft
Commit diff between last tag and master: 0.19.1...master
Checklist:
samesiteparameter onset_cookie#1590add generics type parameters to ImmutableMultiDict #1449moved to the next milestoneAllow staticfiles to follow symlinks outside directory #1377moved to the next milestone