Add typing.Optional on missing annotations

[Kludex]

There was a previous comment by @tomchristie about adding typing.Optional where is missing in a single PR.

I can't find the comment.

Note: I need to add no-implicit-optional on mypy configuration.

[odiseo0]

I have a question why use
import typing
instead of
from typing import Optional, Sequence, Callable
Is there a code style guide for contributing in Starlette?

[Kludex]

I have a question why use
import typing
instead of
from typing import Optional, Sequence, Callable
Is there a code style guide for contributing in Starlette?

It's just to comply with the current pattern you see around in the code.

[odiseo0]

I have a question why use
import typing
instead of
from typing import Optional, Sequence, Callable
Is there a code style guide for contributing in Starlette?

It's just to comply with the current pattern you see around in the code.

Understood, thanks

[Kludex]

I've added no_implicit_optional, so we don't have a future regression on this subject. I've also ignored this rule on testclient.py, as we are thinking about changing the implementation there.

@adriangb Does your approval stands after my latest changes?

[adriangb]

Yep I think this is good. I gave this a scroll through, I didn't see anything wrong so if MyPy is happy, I'm happy. LGTM!

[adriangb]

👍 good call