Proof of concept for detecting stream double consumption#1528
Closed
adriangb wants to merge 6 commits intoKludex:masterfrom
Closed
Proof of concept for detecting stream double consumption#1528adriangb wants to merge 6 commits intoKludex:masterfrom
adriangb wants to merge 6 commits intoKludex:masterfrom
Conversation
Contributor
Author
|
An alternative to all of this might be to wrap the stream with something that always returns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #1519 (comment) instead of "fixing" this issue we may want to want to write better documentation and warn/raise exceptions.
This is a proof of concept for how we might go about detecting problematic behaviors or raising errors.
I'm not sure that raising a runtime error here is exactly the only thing we want to do.
We could:
b""so that the endpoint doesn't fail and instead interprets this as "nothing left in the body"There are obviously many variations to this, but I think the mechanisms I'm proposing here could apply to all of them.