Replace WebSocket assertions with RuntimeError#1472
Merged
aminalaee merged 6 commits intoKludex:masterfrom Feb 4, 2022
Merged
Conversation
aminalaee
changed the title
aminalaee
commented
Feb 3, 2022
| async def asgi(receive, send): | ||
| websocket = WebSocket(scope, receive=receive, send=send) | ||
| await websocket.accept() | ||
| websocket.client_state = WebSocketState.CONNECTING |
Contributor
Author
There was a problem hiding this comment.
I couldn't test this without modifying the client state.
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Looks great yup! I've got a small suggestion on the text for the four message_type cases, which I'll address inline.
| if message_type != "websocket.connect": | ||
| raise RuntimeError( | ||
| 'WebSocket is not connected. Need to call "accept" first.' | ||
| ) |
Contributor
There was a problem hiding this comment.
What do we think about this kind of style for the message_type case?...
f'Expected ASGI message "websocket.connect", but got {message_type!r}'
…com:aminalaee/starlette into switch-websockets-asserts-with-runtimeerror
Kludex
reviewed
Feb 4, 2022
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
lovelydinosaur
approved these changes
Feb 4, 2022
|
What version of |
Contributor
Author
|
@dave-fitzgerald-bc It will be available in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1471.
Switching public facing WebSocket assertions to RuntimeError.