Add support for functools.partial in WebsocketRoute#1356
Merged
Conversation
Contributor
Author
|
I'll try to refactor the tests for partial Route tests. |
aminalaee
added a commit
that referenced
this pull request
Dec 13, 2021
Add support for functools.partial in WebsocketRoute (#1356) * Add support for functools.partial in WebsocketRoute * remove commented code * Refactor tests for partian endpoint and ws Fix snippet on config.md (#1358) * Fix snippet on config.md * Update docs/config.md Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com> Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com> remove outdated test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1355.
Support for using
functools.partialwithRouteis already added. This PR adds support forWebSocketRoute.