Change default chunk size from 4Kb to 64Kb#1345
Merged
Conversation
|
The related issue in httpcore : encode/httpcore#135 |
Kludex
commented
Dec 3, 2021
Owner
Author
|
Thanks @dalf ! Much appreciated! 🎉 |
florimondmanca
approved these changes
Dec 5, 2021
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Looking good! That's quite a similar change to the one we made in HTTPX indeed, and for the same reason (improving transfer speed by using larger chunks).
Owner
Author
|
Thanks @florimondmanca ! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tomchristie On that issue, you said that "httpx uses 64k read size", but I couldn't find that. Do you mind pointing me out what did you mean?