Fixed - async __call__ not run/awaited in the BackgroundTask#1256
Fixed - async __call__ not run/awaited in the BackgroundTask#1256dpr-0 wants to merge 13 commits intoKludex:masterfrom dpr-0:support-async-callable-obj
Conversation
Kludex
left a comment
There was a problem hiding this comment.
On starlette/endpoints.py we also use the same asyncio.iscoroutinefunction. We probably want to use the same iscoroutinefunction there as well.
Maybe we should move the function to other module?
|
Yeah, so should I work on this branch or checkout to a new branch for this |
|
It can be here. |
I see. Thanks for reviewing this pull request. Considering current module names might be not completely suitable for this function, it seems like there can be a new module like |
|
I guess the function was moved, so we could also do the replacement on the |
Hi, I am back for this thread. Should I do the replacement now? |
|
I'm not sure. I think we should look for #1444, but I don't know the opinion of the other members. |
Yeah, I understand that, please let me know if there is any update about this thread. Thanks. |
|
Thank you for the patience here! 🙇♂️ |
Reference to #886