Skip to content

Make Jinja2Templates.get_env private & rename #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JayH5 merged 2 commits into from
Jun 27, 2021
Merged

Make Jinja2Templates.get_env private & rename #1218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e375b4
make-jinja2-get-env-internal
aminalaee Jun 26, 2021
4878ba1
rename _get_env to _create_env
aminalaee Jun 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions starlette/templating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ class Jinja2Templates:

def __init__(self, directory: str) -> None:
assert jinja2 is not None, "jinja2 must be installed to use Jinja2Templates"
self.env = self.get_env(directory)
self.env = self._create_env(directory)

def get_env(self, directory: str) -> "jinja2.Environment":
def _create_env(self, directory: str) -> "jinja2.Environment":
@pass_context
def url_for(context: dict, name: str, **path_params: typing.Any) -> str:
request = context["request"]
Expand Down