Accept exception_handlers as Mapping#1139
Closed
antonagestam wants to merge 4 commits intoKludex:masterfrom
Closed
Accept exception_handlers as Mapping#1139antonagestam wants to merge 4 commits intoKludex:masterfrom
antonagestam wants to merge 4 commits intoKludex:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
2 tasks
Contributor
|
I do think |
Contributor
|
@antonagestam Will you update this? |
aminalaee
suggested changes
Dec 13, 2021
Author
|
I'll try to get to addressing this soon. |
Author
|
Updated to use a contravariant typevar, which makes this also close #1142. |
Owner
|
This was closed by #1360. Thanks for the PR @antonagestam ! :) |
Author
|
@Kludex Oh, note that I updated this PR to solve the problem without introducing |
Owner
|
Cool! I've opened again! :) |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does two things: the first is that it communicates to the caller that the passed dict isn't going to be mutated. The second is that it allows the caller to pass any Mapping without first casting it to a dict, which is very redundant since that already happens inside
__init__.