Merged
Conversation
euri10
approved these changes
Feb 2, 2021
|
|
||
| ### Changed | ||
|
|
||
| * Fixed `ServerErrorMiddleware` compatibility with Python 3.9.1/3.8.7 when debug mode is enabled - |
Contributor
There was a problem hiding this comment.
I'm not a changelog pro but I'd put these 2 items under Fixed since the functionality does not change
Contributor
Author
There was a problem hiding this comment.
Yeah I had a similar thought 😅 we've only used these subheadings recently and was trying to be consistent with how it's been done in the past. All of these fall under "Fixed", I think, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
ServerErrorMiddlewarecompatibility with Python 3.9.1/3.8.7 when debug mode is enabled - #1132.ResourceWarnings when using theTestClientwith WebSocket endpoints - Fix middleware traceback fetching on Python 3.8+, fix ResourceWarnings in TestClient, fix CI build #1132.asyncendpoints wrapped infunctools.partialon Python 3.8+ - #1106.