Allow the use of a custom protocol #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamaileon
force-pushed
the
custom-protocol
branch
2 times, most recently
from
ccaa41e to
e622a4f
Compare
|
Hi @khamaileon, could you explain the use-case for this? I think I get it and should probably be fine, but it's a pretty big piece of public API to support so I'd like to understand how you're using it a better. Some tests/docs would also be helpful. The code in this MR seems fine, so mainly want to clarify it. |
khamaileon
force-pushed
the
custom-protocol
branch
from
e622a4f to
5ef6c4e
Compare
khamaileon
force-pushed
the
custom-protocol
branch
from
6991196 to
04ef1be
Compare
khamaileon
force-pushed
the
custom-protocol
branch
from
04ef1be to
c6cbede
Compare
|
Happy to reopen if author replies the above. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.